Support website links in client list and fix template variable shadowing #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Le <Alex.Le@improving.com>
Signed-off-by: Alex Le <Alex.Le@improving.com>
Aryex
changed the title
stockholmux
approved these changes
Nov 25, 2025
Member
stockholmux
left a comment
stockholmux
left a comment
There was a problem hiding this comment.
LGTM. @Aryex Did the 'variable shadowing' actually cause problems? My understanding is the tera templates had short term contexts unless explicitly global.
Contributor
Author
It seems so. For clients without a website, it was still rendering the first website When I tried renaming the clients it fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is a proposal to add a website link to the client list page to support linking the new Valkey GLIDE website.
It also fixes a bug in the template file.
Issue
The client page only display repo links and does not support website link.
Adding Website Links
The template now displays a link to the client's website, if one is provided in the client's data file. This is handled by conditionally rendering the link only when a non-empty website URL is available.
Here's what the python section looks like:
Fixes Variable Shadowing
Resolves an issue where a
clientvariable was being shadowed within a loop, which could lead to unpredictable behavior. The shadowing variable has been renamed tofirst_client.Related issues
#416